Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If max_results set to 0, return count of issues instead of issues #167

Merged
merged 1 commit into from
Jul 19, 2016
Merged

If max_results set to 0, return count of issues instead of issues #167

merged 1 commit into from
Jul 19, 2016
+15 −0

Conversation

Simwar
Copy link

@Simwar Simwar commented Jul 18, 2016

Added a use case when Max_Results = 0.
It returns the count of issues and not an array of issues (which should be empty).

People use Max_Results = 0 to only get the count of the issues and not the datas of the issues.

Added one test for it.

@Simwar
Copy link
Author

Simwar commented Jul 19, 2016

Hello @bobbrodie

Can you take a look at this MR ? It's simpler and I added test.
The use case is much simpler too.

Thanks

@bobbrodie bobbrodie merged commit 47f5ab8 into sumoheavy:master Jul 19, 2016
@rompic rompic mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simwar @bobbrodie